Skip to content

chore(Topology/Sheaves/SheafCondition/PairwiseIntersections): remove an erw#38508

Open
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:E_7
Open

chore(Topology/Sheaves/SheafCondition/PairwiseIntersections): remove an erw#38508
yuanyi-350 wants to merge 1 commit intoleanprover-community:masterfrom
yuanyi-350:E_7

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • rewrites interUnionPullbackConeLift_left and interUnionPullbackConeLift_right by unfolding interUnionPullbackConeLift directly in the rw chain
  • rewrites the two isLimitPullbackCone branches by adding Functor.mapCone_π_app to the rw chain instead of using erw [← F.1.map_comp]

Extracted from #38415

Open in Gitpod

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels Apr 25, 2026
@yuanyi-350 yuanyi-350 mentioned this pull request Apr 25, 2026
18 tasks
@github-actions
Copy link
Copy Markdown

PR summary 54b0ef5427

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (4.00, 0.01)
Current number Change Type
622 -4 erw

Current commit b3cd21f9d6
Reference commit 54b0ef5427

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant